Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add lighthouse-keeper to integrations #7399

Merged
merged 3 commits into from
Mar 6, 2019
Merged

docs(readme): add lighthouse-keeper to integrations #7399

merged 3 commits into from
Mar 6, 2019

Conversation

StefanoChiodino
Copy link
Contributor

@StefanoChiodino StefanoChiodino commented Mar 6, 2019

Summary

Adds Lighthouse Keeper to the related projects section in the readme.

Related Issues/PRs

Related to #7396

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@StefanoChiodino
Copy link
Contributor Author

I signed the CLA!

Thanks!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

readme.md Outdated
@@ -274,6 +274,8 @@ yarn type-check
## Lighthouse Integrations
This section details services that have integrated Lighthouse data. If you're working on a cool project integrating Lighthouse and would like to be featured here, file an issue to this repo or tweet at us [@_____lighthouse](https://twitter.com/____lighthouse?lang=en)!

* **[Lighthouse Keeper](https://lighthouse-keeper.com/)** - Lighthouse Keeper monitors your pages' Lighthouse scores and notifies you if they drop below your thresholds. You can monitor 3 URLs once a day, for free!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an alphabetized list, mind putting yours after HTTPArchive?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, the others tend to stay away from exclamatory marketing statements ;)

maybe just Lighthouse Keeper is a free service that monitors up to 3 URLs once per day.?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't notice it was alphabetized! I also changed the description as requested. Please resolve and merge if you are happy with this.

Cheers

@patrickhulce
Copy link
Collaborator

patrickhulce commented Mar 6, 2019

Neat service @StefanoChiodino thanks for contributing! 😃

@StefanoChiodino
Copy link
Contributor Author

@patrickhulce thanks for the quick turnaround. I ❤️ Lighthouse, keep up the good work!

@paulirish paulirish changed the title Update readme.md docs(readme): add lighthouse-keeper to integrations Mar 6, 2019
readme.md Outdated
@@ -282,6 +282,8 @@ This section details services that have integrated Lighthouse data. If you're wo

* **[HTTPArchive](http://httparchive.org/)** - HTTPArchive tracks how the web is built by crawling 500k pages with Web Page Test, including Lighthouse results, and stores the information in BigQuery where it is [publicly available](https://discuss.httparchive.org/t/quickstart-guide-to-exploring-the-http-archive/682).

* **[Lighthouse Keeper](https://lighthouse-keeper.com/)** - Lighthouse Keeper is a free service that monitors up to 3 URLs once per day.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this as is...buuuuuut I'd love some more context on what Lighthouse Keeper does for a user? What does monitoring mean here? Do I get emailed when there are regressions? Can I set budgets? Is it a monitoring dashboard where I can see all my sites' scores in one place? Just a thought; otherwise, LGTM.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think his original did a better job of this @exterkamp

"Lighthouse Keeper monitors your pages' Lighthouse scores and notifies you if they drop below your thresholds." SGTY as extra context?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm!

@GoogleChrome GoogleChrome deleted a comment from googlebot Mar 6, 2019
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrickhulce patrickhulce merged commit b834427 into GoogleChrome:master Mar 6, 2019
@patrickhulce
Copy link
Collaborator

Thanks @StefanoChiodino!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants