-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): add lighthouse-keeper to integrations #7399
Conversation
Related to #7396
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed the CLA! Thanks! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
readme.md
Outdated
@@ -274,6 +274,8 @@ yarn type-check | |||
## Lighthouse Integrations | |||
This section details services that have integrated Lighthouse data. If you're working on a cool project integrating Lighthouse and would like to be featured here, file an issue to this repo or tweet at us [@_____lighthouse](https://twitter.com/____lighthouse?lang=en)! | |||
|
|||
* **[Lighthouse Keeper](https://lighthouse-keeper.com/)** - Lighthouse Keeper monitors your pages' Lighthouse scores and notifies you if they drop below your thresholds. You can monitor 3 URLs once a day, for free! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an alphabetized list, mind putting yours after HTTPArchive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, the others tend to stay away from exclamatory marketing statements ;)
maybe just Lighthouse Keeper is a free service that monitors up to 3 URLs once per day.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, didn't notice it was alphabetized! I also changed the description as requested. Please resolve and merge if you are happy with this.
Cheers
Neat service @StefanoChiodino thanks for contributing! 😃 |
@patrickhulce thanks for the quick turnaround. I ❤️ Lighthouse, keep up the good work! |
readme.md
Outdated
@@ -282,6 +282,8 @@ This section details services that have integrated Lighthouse data. If you're wo | |||
|
|||
* **[HTTPArchive](http://httparchive.org/)** - HTTPArchive tracks how the web is built by crawling 500k pages with Web Page Test, including Lighthouse results, and stores the information in BigQuery where it is [publicly available](https://discuss.httparchive.org/t/quickstart-guide-to-exploring-the-http-archive/682). | |||
|
|||
* **[Lighthouse Keeper](https://lighthouse-keeper.com/)** - Lighthouse Keeper is a free service that monitors up to 3 URLs once per day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this as is...buuuuuut I'd love some more context on what Lighthouse Keeper does for a user? What does monitoring mean here? Do I get emailed when there are regressions? Can I set budgets? Is it a monitoring dashboard where I can see all my sites' scores in one place? Just a thought; otherwise, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think his original did a better job of this @exterkamp
"Lighthouse Keeper monitors your pages' Lighthouse scores and notifies you if they drop below your thresholds." SGTY as extra context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @StefanoChiodino! |
Summary
Adds Lighthouse Keeper to the related projects section in the readme.
Related Issues/PRs
Related to #7396