Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: various spelling fixes #7427

Merged
merged 1 commit into from
Mar 11, 2019
Merged

misc: various spelling fixes #7427

merged 1 commit into from
Mar 11, 2019

Conversation

connorjclark
Copy link
Collaborator

thanks to mr chromium robot:
image

connorjclark
connorjclark commented Mar 8, 2019
View reviewed changes
lighthouse-core/report/html/renderer/pwa-category-renderer.js
@@ -32,7 +32,7 @@ class PwaCategoryRenderer extends CategoryRenderer {
const auditRefs = category.auditRefs;

// Regular audits aren't split up into pass/fail/notApplicable clumps, they're
// all put in a top-level clump that isn't expandable/collapsable.
// all put in a top-level clump that isn't expandable/collapsible.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ehhhhhhh

brendankenny
brendankenny approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think vowels used to be more expensive back when we first starting writing the report renderer, but probably time to move on :)

@brendankenny brendankenny merged commit bc84a3e into master Mar 11, 2019
@brendankenny brendankenny deleted the sp branch March 11, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @brendankenny @patrickhulce