core(tap-targets): exclude sticky elements from tap targets audit #7603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattzeunert
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
patrickhulce
approved these changes
Mar 20, 2019
| This is <a>a link in a text block.</a> | ||
| This is <a>a link in a text block.</a> | ||
| This is <a>a link in a text block.</a> | ||
| This is <a>a link in a text block.</a> | ||
| This is <a>a link in a text block.</a> | ||
| </p> | ||
|
|
||
| <a style="background: #afa; top: 0; left: 0; display: block; width: 100vw; height: 800px;"> |
There was a problem hiding this comment.
what are top and left doing here? isn't this element position: static so they will have no effect?
There was a problem hiding this comment.
Good catch, they're not relevant.
brendankenny
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Whether sticky elements overlap depends on the current scroll position, so we should exclude them like we do with position absolute and fixed.
Related Issues/PRs
Pointed out here: #7365 (comment)