Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(smokehouse): set Content-Type for images served by static-server.js #7612

Merged
merged 1 commit into from
Mar 21, 2019
Merged

tests(smokehouse): set Content-Type for images served by static-server.js #7612

merged 1 commit into from
Mar 21, 2019

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Mar 21, 2019 •
edited
Loading

Files served through GAE with no Content-Type get assigned text/html. This caused some image resources to not get checked in the image-aspect-ratio and efficient-animated-content audits in Smokerider.

@paulirish paulirish merged commit b53a167 into master Mar 21, 2019
@paulirish paulirish deleted the static-server-image-content-types branch March 21, 2019 01:01
connorjclark added a commit that referenced this pull request Mar 21, 2019
@connorjclark
tests(smokehouse): set Content-Type for images served by static-serve…
0bc8eaf 
…r.js (#7612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny

@patrickhulce patrickhulce Awaiting requested review from patrickhulce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connorjclark @paulirish