misc(gather): update comment re: ClientRect copying #7785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actually credit to @thebengeu who found the JSONify comment and noticed it didn't actually act like that (anymore): googleads/publisher-ads-lighthouse-plugin#14 (comment) :) |
brendankenny
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the comment is out of date.
getBoundingClientRect used to return a ClientRect which stringified to {}
but as of july 2017, it returns a DOMRect, which stringifies fine.
Still, we dont want all the props, so we'll keep the basic functionality here.
this change is so minor. sorry for the noise.
credit to @brendankenny who brought this up