core(screenshots): match format of final-screenshot #8299
Conversation
patrickhulce
requested review from
brendankenny,
exterkamp and
paulirish
as code owners
| timestamp: targetTimestamp * 1000, | ||
| data: base64Data, | ||
| timestamp: targetTimestamp, | ||
| data: `data:image/jpeg;base64,${base64Data}`, |
There was a problem hiding this comment.
yeah, having the prefix makes sense so no one has to guess what type of image it is, even if it's annoying to add it here
| @@ -30,14 +30,14 @@ describe('Screenshot thumbnails', () => { | |||
| const framePath = path.join(__dirname, | |||
| `../fixtures/traces/screenshots/progressive-app-frame-${index}.jpg`); | |||
| const expectedData = fs.readFileSync(framePath, 'base64'); | |||
| assert.equal(expectedData.length, result.data.length); | |||
| expect(result.data.length - 'data:image/jpeg;base64,'.length).toEqual(expectedData.length); | |||
There was a problem hiding this comment.
heh, I can slice it instead to make it a little more explicit :)
There was a problem hiding this comment.
weird test :)
heh, I can slice it instead to make it a little more explicit :)
ha, I meant the original test is a weird one, but I like the change :)
| const screenshots = await Screenshots.request(trace, context); | ||
| const finalScreenshot = screenshots[screenshots.length - 1]; | ||
|
|
||
| if (!finalScreenshot) { | ||
| throw new LHError(LHError.errors.NO_SCREENSHOTS); | ||
| } | ||
|
|
||
| // trace-of-tab uses microseconds for the timestamp, so we'll convert for consistency | ||
| const finalScreenshotTs = finalScreenshot.timestamp * 1000; |
There was a problem hiding this comment.
computed/screenshots.js is dividing the timestamp by 1000, and this is the only audit using that computed artifact (did we use it for something else at some point?), so, want to just not divide it there?
There was a problem hiding this comment.
yeah sg, I wanted to kill it at some point for being mostly useless, but that'll have to wait for another day :)
|
lol how does that computed artifact have no test for the timestamp :) it should definitely get culled at some point. |
Summary
Reworks our
screenshot-thumbnailsto matchfinal-screenshot. I personally prefer the format used inscreenshot-thumbnailsbut I see the value in an immediately consumable data URI without misinterpretation of what its contents are. I played around with just a mime-type property but then that seemed like overkill so I went back to just matching thedata:image/jpegformat.Potentially we might consider a rename of
.datato.dataURLor something at the same time?Related Issues/PRs
#7752