misc: simplify LH.Config settings types #8630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this doesn't have any material effect, just noticed when looking at budget types that we had an intermediate type we don't need anymore. |
patrickhulce
approved these changes
Apr 26, 2019
| @@ -15,18 +15,14 @@ declare global { | |||
| */ | |||
| export interface Json { | |||
| extends?: 'lighthouse:default' | 'lighthouse:full' | string | boolean; | |||
| settings?: SettingsJson; | |||
| settings?: SharedFlagsSettings; | |||
There was a problem hiding this comment.
seems like we could just call this settings and CliFlags extends settings then :)
There was a problem hiding this comment.
seems like we could just call this settings and CliFlags extends settings then :)
ha, we could. For whatever reason the name SharedFlagsSettings does a poor job to indicate that it's literally "the properties shared by flags and settings" to me :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed this simplification while doing the flags/settings unification stuff.
We needed
extraHeadersto be a more specific type for configJson settings at some point, but it's now the same type as on the baseSharedFlagsSettings, soLH.Config.Json['settings']can just beSharedFlagsSettings, as you'd pretty much expect.