Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(rect-helpers): make getBoundingRect take an array of rectangles #8789

Merged
merged 1 commit into from
May 2, 2019
Merged

core(rect-helpers): make getBoundingRect take an array of rectangles #8789

merged 1 commit into from
May 2, 2019

Conversation

mattzeunert
Copy link
Contributor

Summary

  • we renamed getBoundingRectWithMinimimSize to getBoundingRectWithPadding but the arg was still called minimumSize
  • getBoundingRect can just call through to getBoundingRectWithPadding instead of having its own logic

@mattzeunert mattzeunert mentioned this pull request May 2, 2019
Closed
6 tasks
brendankenny
brendankenny approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔲📐
LGTM

@brendankenny brendankenny merged commit d52421c into master May 2, 2019
@brendankenny brendankenny deleted the getBoundingRectTweaks branch May 2, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattzeunert @brendankenny