Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients(psi): pass score scale to psi #8827

Merged
merged 3 commits into from
May 3, 2019
Merged

clients(psi): pass score scale to psi #8827

merged 3 commits into from
May 3, 2019

Conversation

exterkamp
Copy link
Member

Summary
The new PSI report needs a score scale passed to it! 😄

@exterkamp exterkamp requested a review from paulirish as a code owner May 3, 2019 04:40
brendankenny
brendankenny approved these changes May 3, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

total nit but otherwise LGTM

lighthouse-core/report/html/renderer/psi.js Outdated Show resolved Hide resolved
@brendankenny brendankenny merged commit a91a53d into master May 3, 2019
@brendankenny brendankenny deleted the psi-scorescale branch May 3, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exterkamp @brendankenny