Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: no na-line with single badge #8872

Merged
merged 1 commit into from
May 6, 2019
Merged

report: no na-line with single badge #8872

merged 1 commit into from
May 6, 2019

Conversation

exterkamp
Copy link
Member

Summary
Removes na-line from when gauge has optimized + one other badge.
old | new
image

Related Issues/PRs
fixes: #8856

@exterkamp exterkamp requested a review from paulirish as a code owner May 6, 2019 05:15
brendankenny
brendankenny approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vaguely recall there being a clever solution to this, but ah well :)

This looks like it's a problem in 4.x too, the gauge is just a lot smaller so it's harder to see

@brendankenny brendankenny merged commit b92ceea into master May 6, 2019
@brendankenny brendankenny deleted the pwa-ears branch May 6, 2019 07:42
paulirish pushed a commit that referenced this pull request May 28, 2019
@exterkamp @paulirish
report(pwa): properly hide n/a gauge when it's n/a (#8872)
b7f1c95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PWA badge has white bar always
2 participants
@exterkamp @brendankenny