Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: update minify trace logic to date #8968

Merged
merged 5 commits into from
May 20, 2019
Merged

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented May 16, 2019

Summary
Our trace minification logic got out of sync with some of our lantern improvements of the past few months. This PR fixes that, refactors it to a lib, and adds some tests while we're at it so it won't get out of sync again.

Related Issues/PRs
closes #8949

@brendankenny
Copy link
Member

sorry to be lazy, but could you add some comments about which files moved where vs what's new? :D:D

@brendankenny
Copy link
Member

jk, that might be too lazy. This is two moved files and two new test files :)

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some small things and questions

There's probably an argument for moving them into some sub directory in lib/, but also seems fine enough there :)

lighthouse-core/test/lib/minify-devtoolslog-test.js Outdated Show resolved Hide resolved
lighthouse-core/test/lib/minify-devtoolslog-test.js Outdated Show resolved Hide resolved
lighthouse-core/test/lib/minify-trace-test.js Show resolved Hide resolved
lighthouse-core/lib/minify-devtoolslog.js Outdated Show resolved Hide resolved
lighthouse-core/lib/minify-trace.js Outdated Show resolved Hide resolved
lighthouse-core/lib/minify-trace.js Outdated Show resolved Hide resolved
lighthouse-core/lib/minify-trace.js Show resolved Hide resolved
Co-Authored-By: Brendan Kenny <bckenny@gmail.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert minify-trace to library code
3 participants