-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): Add gimbal integration #9083
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the contribution @mitchellsimoens! Neat stuff!
The "Integrations" section is meant for hosted services that run LH for you in some way. It's a little hard to tell from the https://labs.moduscreate.com/gimbal-web-performance-audit-budgeting link how this is the case.
Maybe this belongs in "Related Projects" just linking to your GitHub repo since all the instructions there are about installing via npm
and running yourself? Or maybe some flashier docs telling the user how they don't need to setup their own infra to get the awesome screenshots you have on the marketing page? 😃
@patrickhulce ah ok, misread the subsection for integration (skipped over the "services" word tbh). Moved it to related projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix meaure
-> measure
and it LGTM. I reworded it to be a little more terse. The second sentence "report...reports" stutters imo. But take it or leave it, just an idea.
Co-Authored-By: Shane Exterkamp <shaneexterkamp5@gmail.com>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@exterkamp thanks for the suggestions! Looks like googlebot is complaining on cla signed now? |
It tends to get confused when non-Googler commits get mixed with Googler commits for some reason. No action needed on your part @mitchellsimoens the Googlebot already knew you signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Summary
Adds the Gimbal integration to the readme