Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): Add gimbal integration #9083

Merged
merged 3 commits into from
Jun 3, 2019
Merged

docs(readme): Add gimbal integration #9083

merged 3 commits into from
Jun 3, 2019

Conversation

mitchellsimoens
Copy link
Contributor

Summary

Adds the Gimbal integration to the readme

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mitchellsimoens
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@mitchellsimoens mitchellsimoens changed the title Add gimbal integration docs(readme): Add gimbal integration May 30, 2019
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the contribution @mitchellsimoens! Neat stuff!

The "Integrations" section is meant for hosted services that run LH for you in some way. It's a little hard to tell from the https://labs.moduscreate.com/gimbal-web-performance-audit-budgeting link how this is the case.

Maybe this belongs in "Related Projects" just linking to your GitHub repo since all the instructions there are about installing via npm and running yourself? Or maybe some flashier docs telling the user how they don't need to setup their own infra to get the awesome screenshots you have on the marketing page? 😃

@mitchellsimoens
Copy link
Contributor Author

@patrickhulce ah ok, misread the subsection for integration (skipped over the "services" word tbh). Moved it to related projects.

Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix meaure -> measure and it LGTM. I reworded it to be a little more terse. The second sentence "report...reports" stutters imo. But take it or leave it, just an idea.

readme.md Outdated Show resolved Hide resolved
Co-Authored-By: Shane Exterkamp <shaneexterkamp5@gmail.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mitchellsimoens
Copy link
Contributor Author

@exterkamp thanks for the suggestions! Looks like googlebot is complaining on cla signed now?

@patrickhulce
Copy link
Collaborator

Looks like googlebot is complaining on cla signed now?

It tends to get confused when non-Googler commits get mixed with Googler commits for some reason. No action needed on your part @mitchellsimoens the Googlebot already knew you signed it!

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exterkamp exterkamp added cla: yes and removed cla: no labels Jun 3, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants