i18n: add es-419

[exterkamp]

Summary
import es-419 and a pt correction.

[patrickhulce]

for everyone else not sure what es-419 is, it's "Latin American Spanish" :)

http://www.localeplanet.com/icu/es-419/index.html

[exterkamp]

I've never added a new locale! Didn't know to add it to the locale.js list & externs! Should be g2g now, --locale=es-419 is different than --locale=es.

[patrickhulce]

Didn't know to add it to the locale.js list & externs

Is there a way to edit my LGTM to make it look like I didn't forget that too? 😆

[paulirish]

much like en-gb, it appears we have to account for the parent/child locales ourselves. Why?? I have no idea.

But here's the list of es-419 child locales: es-AR, es-BO, es-BR, es-BZ, es-CL, es-CO, es-CR, es-CU, es-DO, es-EC, es-GT, es-HN, es-MX, es-NI, es-PA, es-PE, es-PR, es-PY, es-SV, es-US, es-UY, es-VE

Source in the CLDR: https://raw.githubusercontent.com/unicode-cldr/cldr-core/master/supplemental/parentLocales.json

( And tc39/ecma402#87 isn't a thing yet.)

[paulirish]

I know this because I started writing this patch yesterday, before I saw your PR.

But where I went is a dark dark place.... (syntax-wise, at least)

@@ -14,6 +14,9 @@
 
 /** @typedef {Record<string, {message: string}>} LocaleMessages */
 
+const es419 = require('./locales/es-419.json');
+const es419locales = 'es-AR, es-BO, es-BR, es-BZ, es-CL, es-CO, es-CR, es-CU, es-DO, es-EC, es-GT, es-HN, es-MX, es-NI, es-PA, es-PE, es-PR, es-PY, es-SV, es-US, es-UY, es-VE';
+
 // The keys within this const must exactly match the LH.Locale type in externs.d.ts
 /** @type {Record<LH.Locale, LocaleMessages>} */
 const locales = {
@@ -28,6 +31,9 @@ const locales = {
   'en-ZA': require('./locales/en-GB.json'), // Alias of 'en-GB'
   'en-IN': require('./locales/en-GB.json'), // Alias of 'en-GB'
 
+  // https://raw.githubusercontent.com/unicode-cldr/cldr-core/master/supplemental/parentLocales.json
+  ...Object.fromEntries(es419locales.split(', ').map(locale => [locale, es419])),
+
   // All locales from here have a messages file, though we allow fallback to the base locale when the files are identical
   'ar-XB': require('./locales/ar-XB.json'), // psuedolocalization
   'ar': require('./locales/ar.json'),

🤢

[connorjclark]

i like it

[brendankenny]

no fromEntries yet (Node 10)

[paulirish]

yah fromEntries ended up being a pain in the ass. Node 10 and TSC both being real cranky about it. Not worth it.

[exterkamp]

TL;DR fancy js is fancy, but fancy regex replacements is also fancy, and much easier.

I don't know what we need for i18n these days :)

[exterkamp]

Tagging as part of: #7238