-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: enable local debug locale, en-XL #9192
Conversation
can you explain this like i'm an idiot ... (just dig deep and pretend) EDIT: oh, |
Yeah, basically. It also has some cool stuff, notice, the metrics section the It was mentioned here as well: #7010 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay it's back! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Revive locally generating
en-XA
! Since the tc/en-XA
doesn't work* and we want an immediate feedback loop for i18n PRs we should bring back localen-XA
generation!Looks pretty dope too:
You can see why not having placeholders is dangerous:
Definite hack to get the nested braces to work for plurals, but hey it works:
*tc/
en-XA
will work again once #9114 is landed and fully in tc/ 😄Related Issues/PRs
part of: #7238
Future work
ar-XB
locally too 😮