Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: fix yarn.lock and translations master drift #9404

Merged
merged 1 commit into from
Jul 18, 2019
Merged

misc: fix yarn.lock and translations master drift #9404

merged 1 commit into from
Jul 18, 2019

Conversation

connorjclark
Copy link
Collaborator

These changes are from running yarn and yarn update:sample-json on master.

@connorjclark connorjclark mentioned this pull request Jul 18, 2019
Closed
@brendankenny
Copy link
Member

see #9396, #9355, etc :)

patrickhulce
patrickhulce approved these changes Jul 18, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@connorjclark
Copy link
Collaborator Author

see #9396, #9355, etc :)

I am failing to interpret this. You want those other PRs to resolve these problems or are you just explaining why this happened (which I didn't bother to look into, glad you did)?

paulirish
paulirish approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll get this in now so we don't need to carry it in every review.

@paulirish paulirish merged commit 13dc309 into master Jul 18, 2019
@paulirish paulirish deleted the fix-master-drift branch July 18, 2019 17:27
@brendankenny
Copy link
Member

we'll get this in now so we don't need to carry it in every review.

Or we could, you know, review the thing that fixed it 7 days ago

@brendankenny brendankenny mentioned this pull request Jul 18, 2019
Merged
paulirish pushed a commit that referenced this pull request Nov 6, 2019
@connorjclark @paulirish
misc: fix yarn.lock and translations master drift (#9404)
68b03f2
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@paulirish paulirish paulirish approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny

@exterkamp exterkamp Awaiting requested review from exterkamp

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@connorjclark @brendankenny @paulirish @patrickhulce @googlebot