core(unused-css): allow up to 10KB of unused CSS per file #9479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Jul 30, 2019
| @@ -19,7 +19,9 @@ const UIStrings = { | |||
|
|
|||
| const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings); | |||
|
|
|||
| const IGNORE_THRESHOLD_IN_BYTES = 2048; | |||
| // Allow 10KB of unused CSS to permit `:hover` and other styles not used on a non-interactive load. | |||
| // @see https://github.com/GoogleChrome/lighthouse/issues/9353 for more discussion. | |||
There was a problem hiding this comment.
I wish we had a better link for this discussion (there's a lot of other stuff going on in that thread :)
|
Yeah as with all these numbers I don't think there's ever been a hard and fast rule, and it's mostly been saying aloud "hey I'm gonna ignore stuff less than 2KB, sounds good?". If someone would like to come up with a grand unifying theory of "this exact number of byte savings is small enough to not flag to the user" that isn't the lantern simulation savings we already have, be my guest :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumping the allowable limit to 10KB of unused CSS per file per discussion in #9353 (comment). Should have minimal impact on displayed results since the 8KB difference would be unlikely to significantly impact any metrics to appear in the first place.
Related Issues/PRs
closes #9353