core(audits): Point best practices audit links to web.dev #9538
Conversation
mfriesenhahn
requested review from
brendankenny,
exterkamp,
patrickhulce and
paulirish
as code owners
| @@ -15,8 +15,8 @@ const UIStrings = { | |||
| failureTitle: 'Page lacks the HTML doctype, thus triggering quirks-mode', | |||
| /** Description of a Lighthouse audit that tells the user why they should define an HTML doctype. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */ | |||
| description: 'Specifying a doctype prevents the browser ' + | |||
| 'from switching to quirks-mode. Read more on the ' + | |||
| '[MDN Web Docs page](https://developer.mozilla.org/en-US/docs/Glossary/Doctype)', | |||
There was a problem hiding this comment.
man we're really not making good progress on getting rid of Learn more are we team 😆
(I think this is the right thing to do here @mfriesenhahn, just a bummer that we've been talking about following our own advice for a long time and it's sad to see one more convert to "Learn more")
| @@ -17,7 +17,7 @@ const UIStrings = { | |||
| /** Description of a Lighthouse audit that tells the user why and how they should secure cross-origin links. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */ | |||
| description: 'Add `rel="noopener"` or `rel="noreferrer"` to any external links to improve ' + | |||
| 'performance and prevent security vulnerabilities. ' + | |||
| '[Learn more](https://developers.google.com/web/tools/lighthouse/audits/noopener).', | |||
| '[Learn more](https://web.dev/external-anchors-use-rel-noopener).', | |||
There was a problem hiding this comment.
FWIW this doc just came up in #9531 about possibly needing some tweaks
There was a problem hiding this comment.
I've added this comment to web.dev issue 1342 for tracking.
| 'from switching to quirks-mode. Read more on the ' + | ||
| '[MDN Web Docs page](https://developer.mozilla.org/en-US/docs/Glossary/Doctype)', | ||
| 'from switching to quirks-mode. ' + | ||
| '[Learn more](https://web.dev/doctype).', |
There was a problem hiding this comment.
This can probably fit with the line above.
| @@ -31,7 +31,7 @@ const UIStrings = { | |||
| `depth < ${MAX_DOM_TREE_DEPTH} elements and fewer than ${MAX_DOM_TREE_WIDTH} ` + | |||
| 'children/parent element. A large DOM can increase memory usage, cause longer ' + | |||
| '[style calculations](https://developers.google.com/web/fundamentals/performance/rendering/reduce-the-scope-and-complexity-of-style-calculations), ' + | |||
There was a problem hiding this comment.
Just curious if style calculations and layout reflows will be replaced sometime?
There was a problem hiding this comment.
Probably! 😄
@addyosmani can probably give a better sense of the priority of those docs relative to other stuff in the perf section.
Summary