misc: update favicon to new logo #9591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exterkamp
approved these changes
Aug 21, 2019
| @@ -186,7 +186,7 @@ | |||
| }, | |||
| { | |||
| "path": "./dist/viewer/src/viewer.js", | |||
| "maxSize": "75 kB" | |||
| "maxSize": "76 kB" | |||
patrickhulce
approved these changes
Aug 22, 2019
only 32x32 is used here. I just showed 16x16 to convey what reducing byte cost would look like |
gotcha 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I resized the logo to 32x32 and base64 encoded that.
This image shows 16x16, which is lower quality, but smaller ...the extra size from 32x32 is probably ndb