-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lighthouse-viewer): replace deprecated uglify-es with terser #9594
Conversation
async/await will work now, yes? don't change anything yet - I don't want conflicts w/ my viewer changes. one of use could follow up later and async/await the things here. just wanna ensure it works now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it will, it should have all es7-8 features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @wardpeet!
The one issue I see is the output isn't in strict mode since it no longer has a |
not seeing a way to get |
good catch @brendankenny, i've added the |
ah, nice fix :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
I'm replacing uglify-es with terser to minify our viewer.js. Terser has been the successor to uglify-es as it's not actively maintained anymore.
Related Issues/PRs
Fixes #9558