Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients(devtools): remove version replacement for expectations #9702

Merged
merged 1 commit into from
Sep 23, 2019
Merged

clients(devtools): remove version replacement for expectations #9702

merged 1 commit into from
Sep 23, 2019

Conversation

connorjclark
Copy link
Collaborator

the rebase command does it anyway

@paulirish tried to tell me this was weird but i didnt listen.

brendankenny
brendankenny approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these terrible bash scripts get like two more waffling changes until we kick them out and they can live in devtools-frontend :P

@brendankenny brendankenny merged commit c936108 into master Sep 23, 2019
@brendankenny brendankenny deleted the devtools-roll branch September 23, 2019 16:10
paulirish pushed a commit that referenced this pull request Nov 6, 2019
@connorjclark @paulirish
clients(devtools): remove unnecessary code (#9702)
2730fe5
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @brendankenny @googlebot