Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang version used in App Engine #2382

Closed
SaitejaTamma opened this issue Nov 23, 2021 · 4 comments · Fixed by #2563
Closed

Update golang version used in App Engine #2382

SaitejaTamma opened this issue Nov 23, 2021 · 4 comments · Fixed by #2563
Assignees
Labels
kind/feature New features for Agones
Milestone

Comments

@SaitejaTamma
Copy link
Contributor

SaitejaTamma commented Nov 23, 2021

Is your feature request related to a problem? Please describe.
Update the go runtime used in App Engine for the website.

Describe the solution you'd like
Updating the version of go will remove the warning printed while running make site-deploy during the release process.

Describe alternatives you've considered
Ignore the warning until things break.

Additional context
WARNING: Go 1.13 is no longer supported by the Go community as of August 2020. We recommend you to upgrade to the latest version of Go runtime as soon as possible. For details on upgrading, see https://cloud.google.com/appengine/docs/standard/go/runtime.

@SaitejaTamma SaitejaTamma added the kind/feature New features for Agones label Nov 23, 2021
@markmandel
Copy link
Member

For context: Which make command did you run that resulted in this message?

@roberthbailey
Copy link
Member

Offending line:

runtime: go113

@roberthbailey
Copy link
Member

I updated the issue with more context. This happens during the release process while deploying the website.

@roberthbailey roberthbailey changed the title update version for app engine Update golang version used in App Engine Nov 23, 2021
@roberthbailey
Copy link
Member

From https://cloud.google.com/appengine/docs/standard/go/runtime it looks like we can choose go 1.12, 1.13, 1.14, 1.15, or 1.16.

Given that we've been using 1.13 for a long time and it's been deprecated for a year and a half, I think we should jump to 1.16 (unless that breaks something) to give ourselves the maximum amount of time before we need to update again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants