Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move NodeExternalDNS to stable #2643

Closed
4 tasks done
markmandel opened this issue Jun 23, 2022 · 2 comments · Fixed by #2660
Closed
4 tasks done

Move NodeExternalDNS to stable #2643

markmandel opened this issue Jun 23, 2022 · 2 comments · Fixed by #2660
Assignees
@SaitejaTamma
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones
Milestone
1.25.0

Comments

@markmandel
Copy link
Member

markmandel commented Jun 23, 2022 •
edited by SaitejaTamma
Loading

Is your feature request related to a problem? Please describe.

NodeExternalDNS has been in beta since 1.19.0

Describe the solution you'd like
Move it to stable, since it's been in Beta and turned on by default for a while.

Describe alternatives you've considered

Remove it, but I don't think there's a strong reason for that. 😄

Additional context

Task list:
@markmandel markmandel added kind/feature New features for Agones help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jun 23, 2022
@markmandel
Copy link
Member Author

Pinging all the people I can find associated - triple checking it's working as intended:
@himanshu007-creator, @nanasi880

And if anyone has objections, please do let us know.

@nanasi880
Copy link
Contributor

Sounds good.
I using this feature since I wrote NodeExternalDNS and to this day it is working fine.

@SaitejaTamma SaitejaTamma self-assigned this Jun 28, 2022
@SaitejaTamma SaitejaTamma mentioned this issue Jul 6, 2022
Merged
@SaitejaTamma SaitejaTamma added this to the 1.25.0 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaitejaTamma SaitejaTamma

Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones
Projects
None yet
Milestone
1.25.0
Development

Successfully merging a pull request may close this issue.

NodeExternalDNS/stable SaitejaTamma/agones
3 participants
@markmandel @nanasi880 @SaitejaTamma