Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for the extended Kubernetes API #409

Closed
2 tasks
markmandel opened this issue Nov 9, 2018 · 11 comments
Closed
2 tasks

Documentation for the extended Kubernetes API #409

markmandel opened this issue Nov 9, 2018 · 11 comments
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/documentation Documentation for Agones
Milestone

Comments

@markmandel
Copy link
Member

When we implement CRDs for Agones, we create new API endpoints for each CRD.

It would be great to document these, and publish it somewhere, so that people can more easily integrate, and we can reference it in our documentation.

I feel there are several steps:

  1. Create a make target that generates the documentation
  2. Determine where it can be hosted (App engine?), integrate it into our build system and domain controls (@markmandel would need to do this part, most likely)

Resources

@markmandel markmandel added help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! kind/documentation Documentation for Agones labels Nov 9, 2018
@markmandel
Copy link
Member Author

This is currently blocked by: kubernetes-sigs/kubebuilder#483

Will wait for it to get fixed.

@markmandel
Copy link
Member Author

markmandel commented Jan 3, 2019

Another tool to try out: https://github.com/ahmetb/gen-crd-api-reference-docs (this looks way more promising)

@markmandel markmandel added this to the 0.8.0 milestone Jan 9, 2019
@markmandel markmandel modified the milestones: 0.8.0, 0.9.0 Feb 13, 2019
@ahmetb
Copy link

ahmetb commented Feb 13, 2019

Any interest? I can help you get this done in ~20 minutes.

@markmandel
Copy link
Member Author

Yep, definitely! Just haven't got to it yet!

Will need to integrate it into our build image, and our Make targets so we can regenerate on model change though!

@aLekSer
Copy link
Collaborator

aLekSer commented Mar 7, 2019

I see that Kubebuilder has an issue and functionality "Generate docs" seems to be not supported yet.
kubernetes-sigs/kubebuilder#483
Therefore this @ahmetb's project gen-crd-api-reference-docs would be really helpful.
@markmandel I can help with this task. By the way should we integrate all these pages to Hugo ?

@markmandel
Copy link
Member Author

Yeah, if there is a way we can integrate this into agones.dev somehow, I think that would be ideal 👍

Maybe whenever we run make site-static is generates the API?

@aLekSer
Copy link
Collaborator

aLekSer commented Mar 7, 2019

I need to investigate more on how generated docs would look like and how to integrate them into site-static flow.

@markmandel
Copy link
Member Author

@aLekSer can we close this now?

@markmandel
Copy link
Member Author

Whoops - hit the wrong button, but @aLekSer should we reopon this?

@aLekSer
Copy link
Collaborator

aLekSer commented Apr 1, 2019

Agree with closing that, I think the main part is done, the rest is to polish current version, only some small warnings while parsing "./pkg/apis/stable/v1alpha1/" occurred:

I0401 07:45:21.445044       8 main.go:116] parsing go packages in directory ../../../agones.dev/agones/pkg/apis/stable/v1alpha1/
I0401 07:47:56.364115       8 main.go:202] using package=agones.dev/agones/pkg/apis/stable/v1alpha1
W0401 07:47:56.392406       8 main.go:343] not found external link source for type k8s.io/apimachinery/pkg/util/intstr.IntOrString
W0401 07:47:56.393399       8 main.go:343] not found external link source for type k8s.io/apimachinery/pkg/types.UID
W0401 07:47:56.394154       8 main.go:343] not found external link source for type k8s.io/apimachinery/pkg/types.UID

@ahmetb
Copy link

ahmetb commented Apr 1, 2019

Yeah we can probably make them lower level logs instead of warnings. If they bother you, feel free to make small PR to the generator!

@markmandel markmandel modified the milestones: 0.10.0, 0.9.0 Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/documentation Documentation for Agones
Projects
None yet
Development

No branches or pull requests

3 participants