Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can only check for diff against existing branch #11

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

jpoehnelt
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@jpoehnelt jpoehnelt closed this Mar 18, 2020
@jpoehnelt jpoehnelt reopened this Mar 18, 2020
@jpoehnelt jpoehnelt merged commit 2d9a019 into master Mar 18, 2020
@jpoehnelt jpoehnelt deleted the fix/branch_diff branch March 18, 2020 23:44
googlemaps-bot pushed a commit that referenced this pull request Mar 19, 2020
# [1.1.0](v1.0.3...v1.1.0) (2020-03-19)

### Bug Fixes

* can only check for diff against existing branch ([#11](#11)) ([2d9a019](2d9a019))
* dry_run should work when no branch ([bf20980](bf20980))
* **actions/gapic:** only push if necessary ([3f38e4f](3f38e4f))

### Features

* add dry_run option ([#8](#8)) ([106379e](106379e))
@googlemaps-bot
Copy link
Collaborator

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants