Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Easier Exclusions and rules #234

Closed
rayman89 opened this issue May 23, 2015 · 11 comments
Closed

Request: Easier Exclusions and rules #234

rayman89 opened this issue May 23, 2015 · 11 comments

Comments

@rayman89
Copy link

Could you add the functionality to right click the list of blocked elements (chrome://ublock0/content/logger-ui.html) on the page to add it to the exceptions/rules? (Or something similar)

@Snapy
Copy link

Snapy commented May 23, 2015

It's already implemented in the latest dev version. Everything should be explained on the release page.

@ghost
Copy link

ghost commented May 23, 2015

I assume @rayman89 is referring to DOM elements/cosmetic filters, not network requests, @Snapy.

@rayman89
Copy link
Author

I'm referring to both. I installed the dev version but the only thing I noticed is that you can click and a magnifier appears and it shows the menu like if you have clicked on the UBo icon from there i don't know what to do and reading the release page did not clarify anything to me. What I'm asking for is something that lets you easily add exceptions to an element of the page like an script image etc like the functionality ABP has on firefox that you see all the elements of the page (same as that chrome page) and then you can easily create a block or a exclude rule by right clicking on the line and selecting that option.

@ghost
Copy link

ghost commented May 23, 2015

I installed the dev version but the only thing I noticed is that you can click and a magnifier appears and it shows the menu like if you have clicked on the UBo icon from there i don't know what to do and reading the release page did not clarify anything to me.

You're clicking on the wrong pane. Click on the one that's right after the magnifying glass.

@rayman89
Copy link
Author

Oh thanks. Why is that disabled/not enabled for the DOM elements?

@ghost
Copy link

ghost commented May 23, 2015

Why is that disabled/not enabled for the DOM elements?

The functionality isn't implemented. The dev build (https://github.com/gorhill/uBlock/releases/tag/0.9.7.6-dev.1), and this commit (284b4f6) refer to it as "dynamic URL filtering," the keyword being URL. DOM elements are not URLs.

@rayman89
Copy link
Author

Yeah but what i mean is why it was decided not to include the dom elements as well. Are there plans to implement it later?

Also for example I set an exclusion for @@social cause i want the ##.social_icons filter and the ##.bottom_social to be disabled but that exclusion only works with urls and not elements is there a way to make the exclusion disable that cosmetic filter?

@ghost
Copy link

ghost commented May 23, 2015

Also for example I set an exclusion for @@social cause i want the ##.social_icons filter and the ##.bottom_social to be disabled but that exclusion only works with urls and not elements is there a way to make the exclusion disable that cosmetic filter?

@@social refers to network requests
#@#social refers to DOM/cosmetic elements
https://adblockplus.org/en/filters#elemhide_exceptions

Are there plans to implement it later?

Maybe, but I don't develop uBlock, so I'm not the person to ask. These may be of interest to you:
5f1eebb
06334a1
018da9c

@gorhill
Copy link
Owner

gorhill commented May 23, 2015

Are there plans to implement it later

I envision the logger to be the hub for diagnosing/creating filters and rules.

So I do not want any feature requests to be filed, I work best and most productively when I do my own thinking, and prototype then scrap then further prototype solutions, etc. At my own pace.

I know all the needs and I have a lot of ideas of things to try etc., even way beyond whatever people are asking.

Here is the thing: So I will ask people from refraining from filing requests in that area, I will come up with solutions to real issues.

As emphasized in the contributions guideline:

Submit bugs/issues only

I am open to address small feature requests related to minor usability issues, but for major feature requests, I prefer to come up with my own stuff.

@gorhill gorhill closed this as completed May 23, 2015
@gorhill
Copy link
Owner

gorhill commented May 23, 2015

i want the ##.social_icons filter and the ##.bottom_social to be disabled

#@#.social_icons
#@#.bottom_social

For only a specific site:

example.com#@#.social_icons
example.com#@#.bottom_social

@rayman89
Copy link
Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants