uBO 1.11.5rc0 Webextensions under Firefox : No settings save dialog is displayed.

[streetwolf]

Using uBO 1.11.5rc0 Webextensions version under Fx55 Nightly 64 bit.

After clicking on the 'Backup to file' button to save my settings I do not get a dialog asking me where to save the file. The backup temp file that Fx creates is in my Windows Temp folder. This is an interim file Fx creates named something like xxxxxxxxx.fileextension.part. If the dialog was presented to me and I saved it it would have been renamed to uBO's proper backup settings naming convention.

[gorhill]

I do not get a dialog asking me where to save the file

There has never been a dialog, the backup file is saved into whatever folder your browser is set to save downloaded files.

[gorhill]

Although the dialog not showing is not the issue, after trying to reproduce I confirm there is indeed an issue with the webext version of uBO, which is that the backup file is not being saved into the ~/Downloads/ directory on my side, which is where it should have been saved. Need to investigate.

[streetwolf]

People were telling me there was a dialog, The file is being saved in my temp folder as I mentioned. Fx creates this temporary file in case the download is interrupted like exiting Fx. When Fx is run again the download continues. When the download is done the file should go to it's final destination with the proper name. In my case it stops at the Temp folder. uBO does display the file was saved but not to my download folder. Perhaps Webextensions is causing this to happen.

[gorhill]

I get this error in the browser console when trying to back up settings:

> TypeError: this.mDialog is null[Learn More]  nsHelperAppDlg.js:187:5

[streetwolf]

Same message on my system.

[gorhill]

"Export to file" for all other cases (My filters, My rules, Whitelist) works as expected.

[streetwolf]

The Export button does produce a dialog in all cases unlike the backup settings button and does save the file in my download folder.

[gorhill]

The Export button does produce a dialog in all cases

I did not know that, it's not that way on my side. What is "WE"?

[streetwolf]

Webextensions.

[gorhill]

Did you get the dialogs with the legacy version of uBO?

[streetwolf]

Let me setup a new test version of Fx55. I'll try both versions. brb.

[streetwolf]

Created a clean test version of Fx55. Installed uBlock Origin v1.11.4. Backup Settings button gave me a dialog. Save worked as expected. The Export buttons also gave me dialogs.

I then removed 1.11.4 and installed uBO 1.11.5rc0 Webextensions. Backup Settings gave me no dialog and the backup didn't make it to my download folder. Exports worked as expected with dialogs.

[gorhill]

Ok, thanks for investigating. I don't know why I don't get the dialog, personally I prefer this way anwyays.

So I will just re-work a bit the code to ensure that vAPI.download is called from within the dashboard when backing up setting, that is the key difference with other backup buttons.

[streetwolf]

Always glad to help. Let me know if you want me test out the new version when it's ready.

[gwarser]

I cannot create backup on Firefox 54, UBO 1.11.5rc7
"Last backup" date is updated, but no dialog, no file in default download directory, nothing in dev console.
Browser console shows:
21:56:02.152 TypeError: this.mDialog is null[Learn More] nsHelperAppDlg.js:187:5