Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improperly punycoded hostname for hostname-anchored filters with Unicode characters #2599

Closed
gorhill opened this issue May 9, 2017 · 0 comments

Comments

@gorhill
Copy link
Owner

gorhill commented May 9, 2017

Describe the issue

The filter ||atđhe.net/pu/ (and other similar hostname-anchored filters with Unicode characters) is improperly punycoded by uBO at compile time. The filter is currently erroneously compiled to:

||undefinedxn--athe-1ua.net/pu/

Instead of:

||xn--athe-1ua.net/pu/

Occurrences of such improperly parsed filters:

  • EasyList: 3
  • CHN: EasyList China: 0
  • DEU: EasyList Germany: 4
  • FRA: EasyList Liste FR: 2
  • RUS: RU AdList: 14

Not too bad but still, this needs to be fixed for next release.

Steps for anyone to reproduce the issue

I just use dev tools to step into the code, breakpoint at

s = matches[1] + punycode.toASCII(matches[2]) + matches[3];
, which will be triggered when pasting ||atđhe.net/pu/ in My filters.

@gorhill gorhill closed this as completed in ea47cae May 9, 2017
@gorhill gorhill changed the title Improperly punycoded hostname for hostname-anchored filters with Unicode character Improperly punycoded hostname for hostname-anchored filters with Unicode characters May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant