-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uBlock is not blocking ads in about:newtab images #426
Comments
I think this is due to some adware plugin. |
There's no adware whatsoever installed on this pc. This is a freshly installed fedora workstation without any plugins. The captured images for the newtab-page are created from background fetches of pages that do not get their ads properly blocked by uBlock. Here's the js where I assume the thumbnails are fetched: |
There is no adware, Mozilla decided to put ads in the newtab page now. You can go around it by disabling the new tab completely. If my memory serves, gorhill mentioned a filter for uBlock (or uMatrix) that filtered out the tracking aspect of the ads, don't know if it blocks them completely though. Look around the issue pages for something of the sort. |
I don't have any ad yet in my own |
@TeddStriker : @gorhill : |
I see, you means the pages used to generate the thumbnails have ads in them. You point out:
Then this answers it all: uBlock can't do anything either if it's not given an opportunity by the browser to do its job. |
I just had a look at the code, and there's an option to disable thumbnail capturing altogether: |
I did some digging and found the Mozilla bug about this issue: Unfortunately, no progress in nearly two years :( |
@johnp. Nice find! Good that, I browse in InPrivate mode. So, no tracking for me. How ever I assume it should be advisable to disable thumbnail generation setting for all. Perhaps an entry in ublock wiki somewhere. And I assume this is also not captured in dev tools. (Am not in front of a PC, so cannot check my self) |
Can you add this to your OP? So that other people will be able to see the matching Firefox issue without having to go through the whole thread. |
STR:
I didn't see this on my laptop, because of my host-file blocking, but my fedora box shows ads in nearly all of the thumbnails shown (These are in-page ads, captured in the images, and not the "suggested tiles" feature).
I'm also using Add-Ons like NoScript, RequestPolicyContinued and others. Also experimental tracking protection is enabled in Firefox. But somehow it seems that none of them is able to block those ads :(
edit: Here is the Mozilla Bug regarding the issue:
https://bugzilla.mozilla.org/show_bug.cgi?id=904341
The text was updated successfully, but these errors were encountered: