Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBlock is not blocking ads in about:newtab images #426

Closed
johnp opened this issue Jul 1, 2015 · 11 comments
Closed

uBlock is not blocking ads in about:newtab images #426

johnp opened this issue Jul 1, 2015 · 11 comments

Comments

@johnp
Copy link

johnp commented Jul 1, 2015

STR:

  1. Open about:newtab
  2. See ads in the page thumbnails
    I didn't see this on my laptop, because of my host-file blocking, but my fedora box shows ads in nearly all of the thumbnails shown (These are in-page ads, captured in the images, and not the "suggested tiles" feature).

I'm also using Add-Ons like NoScript, RequestPolicyContinued and others. Also experimental tracking protection is enabled in Firefox. But somehow it seems that none of them is able to block those ads :(

edit: Here is the Mozilla Bug regarding the issue:
https://bugzilla.mozilla.org/show_bug.cgi?id=904341

@ElectricRogue
Copy link

I think this is due to some adware plugin.
.

@johnp
Copy link
Author

johnp commented Jul 1, 2015

There's no adware whatsoever installed on this pc. This is a freshly installed fedora workstation without any plugins. The captured images for the newtab-page are created from background fetches of pages that do not get their ads properly blocked by uBlock.

Here's the js where I assume the thumbnails are fetched:
https://dxr.mozilla.org/mozilla-central/source/browser/base/content/newtab/sites.js#214

@TeddStriker
Copy link

There is no adware, Mozilla decided to put ads in the newtab page now. You can go around it by disabling the new tab completely. If my memory serves, gorhill mentioned a filter for uBlock (or uMatrix) that filtered out the tracking aspect of the ads, don't know if it blocks them completely though. Look around the issue pages for something of the sort.

@gorhill
Copy link
Owner

gorhill commented Jul 1, 2015

I don't have any ad yet in my own newtab page. What version of Firefox is required? Is Linux excluded from those ads? In any case, first thing I would do is use the logger to see if I could identify the network requests used to fetch these ads. If the requests can be seen in the logger, uBlock can block them.

@johnp
Copy link
Author

johnp commented Jul 1, 2015

@TeddStriker :
As I've said in my first comment: These are not the "suggested tiles" provided by Mozilla! Please read before posting. Also one does not have to disable the new tab page to get rid of them. Just toggle the "Include suggested sites" check-box and they're gone!

@gorhill :
The inspector doesn't show any request, even during a hard refresh.
The code explicitly states that plugins are disabled for those background loads:
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/thumbnails/BackgroundPageThumbs.jsm#34

@johnp
Copy link
Author

johnp commented Jul 1, 2015

newtab-ads

@gorhill
Copy link
Owner

gorhill commented Jul 1, 2015

I see, you means the pages used to generate the thumbnails have ads in them.

You point out:

The code explicitly states that plugins are disabled for those background loads

Then this answers it all: uBlock can't do anything either if it's not given an opportunity by the browser to do its job.

@johnp
Copy link
Author

johnp commented Jul 1, 2015

I just had a look at the code, and there's an option to disable thumbnail capturing altogether:
browser.pagethumbnails.capturing_disabled = false
Otoh, I'm not sure if 'plugins' explicitly includes Add-Ons...

@johnp
Copy link
Author

johnp commented Jul 1, 2015

I did some digging and found the Mozilla bug about this issue:
https://bugzilla.mozilla.org/show_bug.cgi?id=904341

Unfortunately, no progress in nearly two years :(
I assume this is happening, because they're creating a new custom remote thumbnail browser in the background:
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/thumbnails/BackgroundPageThumbs.jsm#152

@harshanvn
Copy link

@johnp. Nice find!

Good that, I browse in InPrivate mode. So, no tracking for me.

How ever I assume it should be advisable to disable thumbnail generation setting for all. Perhaps an entry in ublock wiki somewhere.

And I assume this is also not captured in dev tools. (Am not in front of a PC, so cannot check my self)

@gorhill
Copy link
Owner

gorhill commented Jul 1, 2015

I did some digging and found the Mozilla bug about this issue:
https://bugzilla.mozilla.org/show_bug.cgi?id=904341

Can you add this to your OP? So that other people will be able to see the matching Firefox issue without having to go through the whole thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants