[v5] onScroll event handler of BottomSheetScrollView ignored on Web

[jer-sen]

Bug

On Web, a handler passed to onScroll props of BottomSheetScrollView is never called.
Indeed, undefined is passed to React Native original component through scrollHandler here:

react-native-bottom-sheet/src/hooks/useScrollHandler.web.ts

Line 167 in 9475a7e

scrollHandler: undefined,

This patch should be applied, tested successfully on my side:

@@ -3,7 +3,9 @@ import { useSharedValue } from 'react-native-reanimated';
 import { useBottomSheetInternal } from './useBottomSheetInternal';
 import { ANIMATION_STATE, SCROLLABLE_STATE } from '../constants';
 import { getRefNativeTag } from '../utilities/getRefNativeTag';
-export const useScrollHandler = () => {
+
+// We add onScroll handler otherwise lost on Web
+export const useScrollHandler = (_, onScroll) => {
   //#region refs
   const scrollableRef = useRef();
   //#endregion
@@ -107,7 +109,7 @@ export const useScrollHandler = () => {
   //#endregion
 
   return {
-    scrollHandler: undefined,
+    scrollHandler: onScroll,
     scrollableRef,
     scrollableContentOffsetY
   };

Environment info

Library	Version
@gorhom/bottom-sheet	5.0.0-alpha.6
react-native	0.72.6
react-native-reanimated	3.3.0
react-native-gesture-handler	2.12.1

Steps To Reproduce

Cf bug section

Reproducible sample code

Cf bug section

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[github-actions]

This issue was closed because it has been stalled for 5 days with no activity.