Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test2json incorrectly attributes output to a subtest, resulting in missing test failure output #66

Closed
dnephin opened this issue Sep 16, 2019 · 6 comments
Labels
test2json-bug A bug in test2json which impacts gotestsum

Comments

@dnephin
Copy link
Member

dnephin commented Sep 16, 2019

Upstream issue: golang/go#29755

Symptoms: gotestsum reports that a test failed, but does not show any failure output in the summary.

Workarounds: Use the standard-verbose format.

Possibly solution: If the bug is not fixed upstream then one solution would be to print the output for the entire top level test, instead of just the output for the subtest.

@dnephin dnephin added the bug Something isn't working label Sep 16, 2019
@dnephin dnephin added test2json-bug A bug in test2json which impacts gotestsum and removed bug Something isn't working labels Oct 5, 2019
@dnephin
Copy link
Member Author

dnephin commented Oct 15, 2019

@dnephin dnephin changed the title test2json incorrectly attributes output to a subtest test2json incorrectly attributes output to a subtest, resulting in missing test failure output Apr 25, 2020
@dnephin
Copy link
Member Author

dnephin commented Oct 31, 2020

The fix for this was included in go1.15, so I think it's probably time to close this issue.

@dnephin dnephin closed this as completed Oct 31, 2020
@edaniels
Copy link

edaniels commented Mar 8, 2023

Without using the workaround, I still see this issue with standard arguments. Including --debug has it sometimes show up.

@dnephin
Copy link
Member Author

dnephin commented Mar 9, 2023

Thanks for the report! Would you mind opening a new issue with info about the Go version used, and if possible steps to reproduce?

From the linked pull request it sounds like maybe it has to do with go test -race output?

@edaniels
Copy link

edaniels commented Mar 9, 2023

Sure

@edaniels
Copy link

edaniels commented Mar 9, 2023

Filed #310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test2json-bug A bug in test2json which impacts gotestsum
Projects
None yet
Development

No branches or pull requests

2 participants