Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Clean Architecture #245

Closed
err0r500 opened this issue Aug 2, 2018 · 9 comments
Closed

Go Clean Architecture #245

err0r500 opened this issue Aug 2, 2018 · 9 comments

Comments

@err0r500
Copy link

err0r500 commented Aug 2, 2018

Hey,
Another golang backend but using clean architecture : https://medium.com/@matthieujacquot/clean-architecture-in-golang-7ebafe4c70db

repo : https://github.com/err0r500/go-realworld-clean

@err0r500
Copy link
Author

err0r500 commented Aug 5, 2018

Hi,
I updated the repo, everything should be ok now.
I'll improve the test coverage in the days to come.
If I have something more specific to do, tell me. 😀

@anishkny
Copy link
Member

anishkny commented Aug 8, 2018

This looks very interesting indeed. Could you run the RW API tests by following instructions here to ensure it adheres? Thanks!

@anishkny anishkny changed the title clean architecture backend (golang) Go Clean Architecture Aug 8, 2018
@err0r500
Copy link
Author

err0r500 commented Aug 9, 2018

Hi @anishkny !

Thanks a lot. I updated the repo in order to have the tests included (with the testing instructions).

About the postman collection : I just changed the order of some requests in order to have the POST requests before the GET/PUT and the DELETE at the end (because, obviously, one can't get something that hasn't been created yet or that has already been deleted).

This way, the whole test suit passes, I hope it's fine.

@err0r500
Copy link
Author

Hey,
I improved the test coverage and discovered while testing with a frontend that articles without comments should return an empty array instead of a null (not covered in newman) along with a few other details of the same kind.
I played a bit with the elm frontend and everything seem to work fine now.
Tell me if it looks good to you :)
Best,

@err0r500
Copy link
Author

Hi,
I don't see any progress in this issue, it's not listed in the main README, so I'm wondering : is something is missing ? What would be the next step ?
Best,

@Cameron-C-Chapman
Copy link
Member

@err0r500 sorry for the delay. We just need to verify it adheres to the spec and works with the front ends. I am on vacation this weekend (starting soon actually) so I won't be able to take a look until sometime next week.

Feel free to keep pinging us to keep it moving, hopefully we can get it added soon.

@err0r500
Copy link
Author

hi !
Is there something missing ?
I tested it with the elm frontend without noticing any problem but if you found something, tell me and I'll try to get it fixed ASAP.
Best,

@err0r500
Copy link
Author

err0r500 commented Dec 9, 2018

Up?

@anishkny
Copy link
Member

anishkny commented Jan 8, 2019

Hi @err0r500 sorry for the delay! Could you send a PR adding this to etc/backend-repos.yaml? Thanks!

Edit: Never mind, added to backend repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants