-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug tracker] New deployed API #712
Comments
@geromegrignon thanks for the temporary API! It seems that login with incorrect credentials fails with a CORS error instead of the expected response. |
Hello, I just fixed it. |
Cool! However it doesn't follow the spec. As is, it breaks the crizmas-mvc implementation. I think the response should be something like:
|
@raulsebastianmihaila fixed too.
|
@geromegrignon Hi , a follow-up from morning's
It shows 401 Unauthorized :
a. register & login & fetch the feed , so far so good b. after sometime(I guess JWT expiration time ?) , when trying to refresh the feed , will get the above error . If cleaning the token in local storage, then it will work again. Token is sent in header : |
I changed the token duration from 100 minutes to 7 days. |
yet another producer-consumer problem LOLL |
changed the token duration to 60 days to match the current deployed API : def generate_jwt
JWT.encode({ id: id,
exp: 60.days.from_now.to_i },
Rails.application.secrets.secret_key_base)
end |
@geromegrignon find an issue(should be the last one..) here. For comment : https://github.com/gothinkster/realworld/tree/master/api#single-comment Here backend should return whole author object instead of |
@Allianzcortex fixed too. Thanks for reporting it! |
@geromegrignon another small issue here : In old implementation , when we retrieve the feed : we can get And currently articles count is only the count we return (ie there will only be 1st page always) |
@Allianzcortex fixed too (i was filtering on offset/limit) |
@geromegrignon Thank you for providing this api endpoints! I found a bug about When request this api, |
Hey @HoPGoldy, thanks for reporting it. |
@geromegrignon seems the register function is losing the temper now ? |
@Allianzcortex Thanks! I made some refactoring to open-source the API source code soon and it resulted in a new bug. |
@raulsebastianmihaila @Allianzcortex the temporary api is now deployed on the original domain: conduit.productionready.io. Feel free to provide me feedback |
@geromegrignon COOOOOLLL. And also looking forward to the open-source of the new implementation! |
@Allianzcortex the repository is here: https://github.com/gothinkster/node-express-prisma-v1-official-app |
@raulsebastianmihaila and @Allianzcortex don't waste your time to test conduit.productionready.io for now. There are some bugs : Such a redirection results in cors errors and query params not passed with the redirection. |
The API now works as expected, I created a PR on repositories using the temporary API. |
error: 404 Not Found /api/articles when creating new article |
hmm interesting @mdsadiqueinam could u provide the payload u use ? I just tested it on my website (https://react-typescript-hooks-realworld.vercel.app/) which uses new API implementation, and a new post can be created successfully. |
I used this https://realworld-temp-api.herokuapp.com/api from swagger ui |
@mdsadiqueinam This API also can't read the feed. The issue should be on how it's deployed rather than how it's implemented. |
Hey @mdsadiqueinam, It might be due to conflicts between the api itself and the swagger documentation. Anyway, i encourage you to follow our documentation about the api : https://gothinkster.github.io/realworld/docs/specs/frontend-specs/api As stated few messages ago, the original api url is now live. I plan to shutdown the temp one soon to avoid multiple maintenance efforts. |
The temporary API will be shut down on Nov 1st as being now available on the original URL https://conduit.productionready.io/api |
A new API is deployed to fix the following issues:
This new API is a temporary solution as we can't deploy on the productionready.io domain.
API URL: https://realworld-temp-api.herokuapp.com/api
I chose not to use an existing backend implementation but to create a new one as a starter for the incoming V2.
Please add a comment here if you find any bugs while using this new API.
Bug tracker:
/api/articles/feed
doesn't retrieve data as expected/api/articles/:slug/comments
response doesn't match the specs format/api/articles/:slug/comments
author info not includedThe text was updated successfully, but these errors were encountered: