Deleting One-Shot leaves empty series in Komga

[PhilippKammann]

Steps to reproduce

1. Create a One-Shot directory (e.g. _oneshots) in the library
2. Set "_oneshots" as the string pattern in library settings
3. Add book to _oneshots and scan
4. Delete the new One-Shot book through the WebUI
5. Empty trash

Expected behavior

The One-Shot series gets removed from the WebUI

Actual behavior

A "ghost" series with not thumbnail remains that will lead to an empty page if clicked upon. The "ghost" series is also present if Komga is opened in a new browser.

Logs

2023-08-08T15:46:12.820+02:00  INFO 1 --- [io-25600-exec-5] o.g.komga.application.tasks.TaskEmitter  : Sending task: DeleteBook(bookId='0D7DZG1HD76MJ', priority='8')

2023-08-08T15:46:12.826+02:00  INFO 1 --- [ntContainer#1-1] o.g.komga.application.tasks.TaskHandler  : Executing task: DeleteBook(bookId='0D7DZG1HD76MJ', priority='8')

2023-08-08T15:46:12.829+02:00  INFO 1 --- [ntContainer#1-1] o.g.komga.domain.service.BookLifecycle   : Deleted file: /library/Manga/_oneshots/Dungeon Reset #0171c.cbz

2023-08-08T15:46:12.834+02:00  INFO 1 --- [ntContainer#1-1] o.g.komga.domain.service.BookLifecycle   : Deleted directory: /library/Manga/_oneshots

2023-08-08T15:46:12.839+02:00  INFO 1 --- [ntContainer#1-1] o.g.komga.domain.service.BookLifecycle   : Soft delete books: [Book(name=Dungeon Reset #0171c, url=file:/library/Manga/_oneshots/Dungeon%20Reset%20%230171c.cbz, fileLastModified=2023-08-08T12:12:22.409, fileSize=7949568, fileHash=830fc095c470494e84d67798f3c73c0c, number=1, id=0D7DZG1HD76MJ, seriesId=0D7DZG1HD76MK, libraryId=04VQ0EJV77XG8, deletedDate=null, oneshot=true, createdDate=2023-08-08T15:45:08, lastModifiedDate=2023-08-08T15:45:11.519)]

2023-08-08T15:46:12.845+02:00  INFO 1 --- [ntContainer#1-1] o.g.komga.application.tasks.TaskHandler  : Task DeleteBook(bookId='0D7DZG1HD76MJ', priority='8') executed in 18.734526ms

2023-08-08T15:46:15.755+02:00  INFO 1 --- [io-25600-exec-9] o.g.komga.application.tasks.TaskEmitter  : Sending task: EmptyTrash(libraryId='04VQ0EJV77XG8', priority='6')

2023-08-08T15:46:15.759+02:00  INFO 1 --- [ntContainer#1-1] o.g.komga.application.tasks.TaskHandler  : Executing task: EmptyTrash(libraryId='04VQ0EJV77XG8', priority='6')

2023-08-08T15:46:15.759+02:00  INFO 1 --- [ntContainer#1-1] o.g.k.d.service.LibraryContentLifecycle  : Empty trash for library: Library(name=Manga/Manwha, root=file:/library/Manga/, importComicInfoBook=true, importComicInfoSeries=false, importComicInfoCollection=false, importComicInfoReadList=false, importComicInfoSeriesAppendVolume=false, importEpubBook=false, importEpubSeries=false, importMylarSeries=false, importLocalArtwork=true, importBarcodeIsbn=false, scanForceModifiedTime=false, repairExtensions=false, convertToCbz=false, emptyTrashAfterScan=false, seriesCover=FIRST, hashFiles=true, hashPages=true, analyzeDimensions=true, oneshotsDirectory=_oneshots, unavailableDate=null, id=04VQ0EJV77XG8, createdDate=2021-04-28T21:15:53, lastModifiedDate=2023-08-04T23:23:18.427)

2023-08-08T15:46:15.760+02:00  INFO 1 --- [ntContainer#1-1] o.g.k.domain.service.SeriesLifecycle     : Delete series ids: []

2023-08-08T15:46:15.760+02:00  INFO 1 --- [ntContainer#1-1] o.g.komga.domain.service.BookLifecycle   : Delete book ids: []

2023-08-08T15:46:15.776+02:00  INFO 1 --- [ntContainer#1-1] o.g.komga.domain.service.BookLifecycle   : Delete book ids: [0D7DZG1HD76MJ]

2023-08-08T15:46:15.787+02:00  INFO 1 --- [ntContainer#1-1] o.g.k.domain.service.SeriesLifecycle     : Sorting books for Series(name=Dungeon Reset #0171c, url=file:/library/Manga/_oneshots/Dungeon%20Reset%20%230171c.cbz, fileLastModified=2023-08-08T12:12:22.409, id=0D7DZG1HD76MK, libraryId=04VQ0EJV77XG8, bookCount=1, deletedDate=null, oneshot=true, createdDate=2023-08-08T15:45:08, lastModifiedDate=2023-08-08T15:45:08)

2023-08-08T15:46:15.793+02:00  INFO 1 --- [ntContainer#1-1] o.g.k.d.s.SeriesCollectionLifecycle      : Deleting empty collections

2023-08-08T15:46:15.795+02:00  INFO 1 --- [ntContainer#1-1] o.g.k.domain.service.ReadListLifecycle   : Deleting empty read lists

2023-08-08T15:46:15.796+02:00  INFO 1 --- [ntContainer#1-1] o.g.komga.application.tasks.TaskHandler  : Task EmptyTrash(libraryId='04VQ0EJV77XG8', priority='6') executed in 36.855350ms

2023-08-08T15:49:51.519+02:00  WARN 1 --- [o-25600-exec-10] o.s.web.servlet.PageNotFound             : No mapping for GET /libraries/04VQ0EJV77XG8/recommended

2023-08-08T16:50:49.551+02:00  WARN 1 --- [io-25600-exec-5] o.s.web.servlet.PageNotFound             : No mapping for GET /libraries/04VQ0EJV77XG8/series

2023-08-08T16:50:50.350+02:00  INFO 1 --- [io-25600-exec-7] o.g.k.domain.service.SeriesLifecycle     : House keeping thumbnails for series: 0D7DZG1HD76MK

2023-08-08T16:50:54.619+02:00  INFO 1 --- [io-25600-exec-3] o.g.komga.application.tasks.TaskEmitter  : Sending task: DeleteSeries(seriesId='0D7DZG1HD76MK', priority='8')

2023-08-08T16:50:54.624+02:00  INFO 1 --- [ntContainer#1-1] o.g.komga.application.tasks.TaskHandler  : Executing task: DeleteSeries(seriesId='0D7DZG1HD76MK', priority='8')

2023-08-08T16:50:54.626+02:00  INFO 1 --- [ntContainer#1-1] o.g.k.domain.service.SeriesLifecycle     : Cannot delete series folder, path does not exist: /library/Manga/_oneshots/Dungeon Reset #0171c.cbz

2023-08-08T16:50:54.626+02:00  INFO 1 --- [ntContainer#1-1] o.g.komga.application.tasks.TaskHandler  : Task DeleteSeries(seriesId='0D7DZG1HD76MK', priority='8') executed in 1.527625ms

2023-08-08T16:51:04.574+02:00  WARN 1 --- [io-25600-exec-8] o.s.web.servlet.PageNotFound             : No mapping for GET /oneshot/0D7DZG1HD76MK

2023-08-08T16:51:06.489+02:00  INFO 1 --- [io-25600-exec-2] o.g.k.domain.service.SeriesLifecycle     : House keeping thumbnails for series: 0D7DZG1HD76MK

2023-08-08T16:51:12.152+02:00  INFO 1 --- [io-25600-exec-4] o.g.k.domain.service.SeriesLifecycle     : House keeping thumbnails for series: 0D7DZG1HD76MK

2023-08-08T16:51:13.619+02:00  WARN 1 --- [io-25600-exec-1] o.s.web.servlet.PageNotFound             : No mapping for GET /libraries/04VQ0EJV77XG8/series

2023-08-08T16:51:14.371+02:00  INFO 1 --- [io-25600-exec-5] o.g.k.domain.service.SeriesLifecycle     : House keeping thumbnails for series: 0D7DZG1HD76MK

2023-08-08T16:57:02.222+02:00  WARN 1 --- [io-25600-exec-6] o.s.web.servlet.PageNotFound             : No mapping for GET /libraries/04VQ0EJV77XG8/series

2023-08-08T16:57:02.908+02:00  INFO 1 --- [io-25600-exec-5] o.g.k.domain.service.SeriesLifecycle     : House keeping thumbnails for series: 0D7DZG1HD76MK

2023-08-08T16:57:19.225+02:00  INFO 1 --- [io-25600-exec-6] o.g.k.domain.service.SeriesLifecycle     : House keeping thumbnails for series: 0D7DZG1HD76MK

Komga version

v1.3.1-master

Operating system

Docker

Other details

(Same book/deletion that lead to #1191 )

Acknowledgements

• I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
• I have written a short but informative title.
• I have checked the FAQ.
• I have updated the app to the latest version.
• I will fill out all of the requested information in this form.

[gotson]

This is consistent with the current behaviour when deleting the last book in a series:

• the book becomes unavailable
• the series remain as-is

If you empty the trash, the unavailable book is removed, and the series remain with no books.

On a subsequent scan, the series will be marked as unavailable.

If you empty the trash, the unavailable series will be removed.

---

For oneshots the only real bug is that clicking the leftover series will take you to the browse oneshot view, which won't render because the book doesn't exist anymore.