Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing version 1 components #298

Closed
taranchauhan opened this issue May 30, 2018 · 2 comments
Closed

Missing version 1 components #298

taranchauhan opened this issue May 30, 2018 · 2 comments

Comments

@taranchauhan
Copy link
Contributor

taranchauhan commented May 30, 2018

@penx @stevesims @Loque-

I have noticed the following components are missing from the V1 goal.

GOV UK Elements Typography

  • WarningText
  • HiddenText

GOV UK Elements Data

  • DataVisualisation

GOV UK Elements Icons Images

  • Image (3:2 Aspect Ratio)

GOV UK Elements Errors

  • ErrorSummaryBox

Is there any particular reason for this or were these either just missed or introduced as new after the issue was created.

Could these be a possible target for V2?

@Loque- Loque- mentioned this issue May 31, 2018
@Joe-Brady
Copy link

ErrorSummaryBox would be very useful for us as a priority!

@Loque-
Copy link
Collaborator

Loque- commented Jun 4, 2018

Thanks @taranchauhan! I've added these to #61 as they should be a part of version 1, excluding the image as it could be time consuming for us to get this right as a component (srcset for example), but also easy for people to implement a 4:3 image in the meantime or create their own image component.

@Loque- Loque- closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants