Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Fix: Fixes autoplay parameter for Audio/Video in Chatbot #10129

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

dawoodkhan82
Copy link
Collaborator

@dawoodkhan82 dawoodkhan82 commented Dec 5, 2024

Description

Fixes autoplay parameter for Audio/Video in Chatbot.

Closes: #9346

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 5, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/0338fdb014a8499d42bb9688d22b4c181affbed5/gradio-5.8.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@0338fdb014a8499d42bb9688d22b4c181affbed5#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/0338fdb014a8499d42bb9688d22b4c181affbed5/gradio-client-1.8.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/0338fdb014a8499d42bb9688d22b4c181affbed5/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 5, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/chatbot patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Quick Fix: Fixes autoplay parameter for Audio/Video in Chatbot

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

abidlabs commented Dec 5, 2024

I tested with this:

import gradio as gr

value = [(
    "Hello",
    gr.Audio("test.wav", autoplay=False)
)]

with gr.Blocks() as demo:
    b = gr.Button()
    c = gr.Chatbot(type="tuples")

    b.click(lambda : value, None, c)

demo.launch()

and what I'm seeing is that the audio starts playing immediately, suggesting that autoplay is now true in all cases. We don't want that, we want the autoplay property to be respected, and by default be turned off.

@dawoodkhan82
Copy link
Collaborator Author

@abidlabs Ah yes! will fix.

@dawoodkhan82
Copy link
Collaborator Author

@abidlabs Seems like the same issue exists for Video.

@dawoodkhan82 dawoodkhan82 changed the title Quick Fix: Fixes autoplay parameter for Audio in Chatbot Quick Fix: Fixes autoplay parameter for Audio/Video in Chatbot Dec 5, 2024
@dawoodkhan82 dawoodkhan82 requested a review from abidlabs December 5, 2024 13:53
Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test for Video, but I can confirm that this solves the issue for Audio!

@abidlabs
Copy link
Member

Will go ahead and merge now that CI is passing!

@abidlabs abidlabs merged commit 2b55302 into main Dec 10, 2024
23 of 24 checks passed
@abidlabs abidlabs deleted the chat-fixes branch December 10, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The autoplay parameter for audio or video does not take effect in Chatbot
3 participants