Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve uploaded file UI in Chatbot #10137

Merged
merged 19 commits into from
Dec 10, 2024
Merged

Improve uploaded file UI in Chatbot #10137

merged 19 commits into from
Dec 10, 2024

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Dec 5, 2024

Description

When a text based file is pasted, it'll look a little bit snazzier now. Only applies to rtf, pdf, and txt files. Any others we should support?

Screenshot 2024-12-09 at 18 10 32

Closes: #10029

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 5, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/19f9e377bae6ff0f69f628360620d7ff484a64d5/gradio-5.8.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@19f9e377bae6ff0f69f628360620d7ff484a64d5#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/19f9e377bae6ff0f69f628360620d7ff484a64d5/gradio-client-1.8.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/19f9e377bae6ff0f69f628360620d7ff484a64d5/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 5, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/chatbot minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Improve uploaded file UI in Chatbot

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hannahblair hannahblair marked this pull request as ready for review December 9, 2024 18:49
@freddyaboulton
Copy link
Collaborator

Only applies to rtf, pdf, and txt files

This is no longer true right? Just tried with a yaml and it worked as I would expect

image

@freddyaboulton
Copy link
Collaborator

Looks great @hannahblair ! One nit is that file displays in assistant messages look a bit off cause of the border (dark and light mode)

image

@hannahblair
Copy link
Collaborator Author

thanks for catching that @freddyaboulton! that's fixed now.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @hannahblair !

@hannahblair hannahblair merged commit fe7a9db into main Dec 10, 2024
24 checks passed
@hannahblair hannahblair deleted the uploaded-file-UI branch December 10, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the UI of uploaded files in Chatbot and MultimodalTextbox
3 participants