-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group chatbot messages by default #10169
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/c5e4d46c5c47779fdc6751496095a2ec5af83f45/gradio-5.8.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@c5e4d46c5c47779fdc6751496095a2ec5af83f45#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/c5e4d46c5c47779fdc6751496095a2ec5af83f45/gradio-client-1.8.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/c5e4d46c5c47779fdc6751496095a2ec5af83f45/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
|
This reverts commit f1ea8f8.
gradio/components/chatbot.py
Outdated
@@ -198,6 +198,7 @@ def __init__( | |||
examples: list[ExampleMessage] | None = None, | |||
show_copy_all_button=False, | |||
allow_file_downloads=True, | |||
display_consecutive_in_same_bubble: bool = True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the parameter name is kinda long. How about group_consecutive_messages
?
Also I don't think the grouping applies if |
Should be good for a re-review now - thanks @hannahblair for fixing the styling. We have omitted borders but fixed the rounding. We tried the borders but we think it looks better without. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks great! Only nit is about shortening the parameter name but otherwise good to me
Description
Closes: #8850
By default, consecutive messages are displayed in the same bubble. This is controlled by the new
display_consecutive_in_same_bubble
param of Chatbot.🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.sh
Please run these bash scripts to automatically format your code:
bash scripts/format_backend.sh
, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh