-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new project specs for Empty and Basic Activity Android Applications #120
base: main
Are you sure you want to change the base?
Conversation
tresat
commented
Sep 17, 2024
•
edited
Loading
edited
- Adds 2 new project init specs for Empty Activity and Basic Activity Android Applications.
- Upgrades project to use Java 17.
- Upgrades Kotlin version to 2.0.20.
- Update to use new Gradle nightly with fixes to Project Init specs.
- Various integration testing fixes and additions.
- Updates KMP plugin to hide Polymorphic container, which is no longer supported.
…egration testing to specifiy type
…udio, fix testing
Polymorphic containers are not supported yet in DCL, so hide this one and expose the (limited) functionality of the known target platform types statically in a non-container interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This overall looks good to me.
There are many pending TODOs so I don't approve right away.
Thanks for the review. This has to wait until the init changes on the Gradle side are finished, or at least stable enough that I can build a nightly and update the wrapper here to use it. I don't want to merge this first. |