Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new project specs for Empty and Basic Activity Android Applications #120

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

tresat
Copy link
Member

@tresat tresat commented Sep 17, 2024

  • Adds 2 new project init specs for Empty Activity and Basic Activity Android Applications.
  • Upgrades project to use Java 17.
  • Upgrades Kotlin version to 2.0.20.
  • Update to use new Gradle nightly with fixes to Project Init specs.
  • Various integration testing fixes and additions.
  • Updates KMP plugin to hide Polymorphic container, which is no longer supported.

@tresat tresat self-assigned this Sep 17, 2024
Polymorphic containers are not supported yet in DCL, so hide this one and expose the (limited) functionality of the known target platform types statically in a non-container interface.
@tresat tresat added the enhancement New feature or request label Sep 20, 2024
@tresat tresat mentioned this pull request Sep 20, 2024
Copy link
Member

@eskatos eskatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks good to me.
There are many pending TODOs so I don't approve right away.

@tresat
Copy link
Member Author

tresat commented Sep 26, 2024

This overall looks good to me. There are many pending TODOs so I don't approve right away.

Thanks for the review. This has to wait until the init changes on the Gradle side are finished, or at least stable enough that I can build a nightly and update the wrapper here to use it. I don't want to merge this first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants