Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java 17 for most of gradle-profiler tests #580

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

asodja
Copy link
Member

@asodja asodja commented Oct 28, 2024

Since we will upgrade Android Studio that supports just Java 17. Additionally in the future Gradle will support only Java 17.

We will keep Linux running with Java 8 for now.

Since we will upgrade Android Studio that supports just Java 17.
Additionally in the future Gradle will support only Java 17.
We will keep Linux running with Java 8 for now.
@asodja asodja self-assigned this Oct 28, 2024
@asodja asodja added the internal Internal change label Oct 28, 2024
""""-Porg.gradle.java.installations.paths=%${os.name}.java8.oracle.64bit%,%${os.name}.java11.openjdk.64bit%""""
""""-Porg.gradle.java.installations.paths=
|%${os.name}.java8.oracle.64bit%,
|%${os.name}.java11.openjdk.64bit%,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 I left Java11 here, since without #579 merged we still use Java11 toolchains

@asodja asodja marked this pull request as ready for review October 28, 2024 09:45
@asodja asodja requested review from blindpirate and cobexer October 28, 2024 09:45
Copy link
Member

@cobexer cobexer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

💅 would be nice if we could reduce the number of places where we repeat Java version numbers

@asodja
Copy link
Member Author

asodja commented Oct 28, 2024

💅 would be nice if we could reduce the number of places where we repeat Java version numbers

True, I removed some repetition by simplifying setting javaHome()

@asodja
Copy link
Member Author

asodja commented Oct 28, 2024

It looks like this needs some more changes, since quite some number of tests break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants