Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Update Graphite support to include functions introduced in the 1.0.0 release. #8261

Closed
bascarsija opened this issue May 1, 2017 · 1 comment
Assignees
Labels
area/datasource datasource/Graphite prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/feature-request
Milestone

Comments

@bascarsija
Copy link

Master (88dd8af at the time of writing) does not support the selection/autocompletion any of the new Graphite functions introduced in the 1.0.0 release, as listed in the release notes.

Issue #2481, which predates the Graphite 1.0.0 release, requests that a specific function (i.e. fallbackSeries()) be added, but @torkelo responded that the function should only be added "when it is available in the latest stable release."

Now that 1.0.0 is available, fallbackSeries() and all of the other functions introduced in 1.0.0 should be added to the set of functions supported by the selection/autocompletion feature.

As an aside, note that #4622 separately requests the addition of a new feature to maintain version-specific function sets and allow users to specify the data source version.

@daniellee daniellee added datasource/Graphite type/feature-request prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels May 2, 2017
@daniellee daniellee added this to the 4.4.0 milestone May 2, 2017
@torkelo torkelo modified the milestones: 5.0, 4.4.0 Jun 26, 2017
@torkelo
Copy link
Member

torkelo commented Jul 31, 2017

Some tips on how to implement

Add Graphite Version option to data source settings

Implement similar to ES version, https://github.com/grafana/grafana/blob/master/public/app/plugins/datasource/elasticsearch/partials/config.html#L26
https://github.com/grafana/grafana/blob/master/public/app/plugins/datasource/elasticsearch/config_ctrl.ts#L24
Add version property and filtering to function definitions
https://github.com/grafana/grafana/blob/master/public/app/plugins/datasource/graphite/gfunc.js#L36
https://github.com/grafana/grafana/blob/master/public/app/plugins/datasource/graphite/gfunc.js#L755

So that function menu / autocomplete only shows functions for your graphite version, add new function definitions for Graphite 1.0 functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/datasource datasource/Graphite prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/feature-request
Projects
None yet
Development

No branches or pull requests

5 participants