Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Color can not be set to "From threshold" in library panel #95513

Closed
ManiMozaffar opened this issue Oct 28, 2024 · 2 comments
Closed

Comments

@ManiMozaffar
Copy link

What happened?

Since last release, when I go to library panel, and I change the value from "Classic palette" to "From threshold", it's not respected and shows me something weird.

How it is when I go to library panel:
Image

How it should be after I choose "From threshold"
Image

When I click save panel, and go back to dashboard page, I still see the weird color scheme.

Note that all library panels were "From threshold", but just today they all became "Classic palette"

What did you expect to happen?

To save the "From threshold", and respect that and keep showing that, just as what it shows me in preview before saving and going back to dashboard page.

Did this work before?

Yes, it was working before until last release. Last time on Friday it was working.

How do we reproduce it?

  1. Create a library panel
  2. Setup some threshold
  3. Put the color to "From threshold"

Is the bug inside a dashboard panel?

No response

Environment (with versions)?

Grafana: Cloud
OS: MacOs
Browser: Chrome

Grafana platform?

I use Grafana Cloud

Datasource(s)?

No response

@kaydelaney
Copy link
Contributor

Looked into this a bit, and it seems like the issue is the color mode being overwritten when the following is called:

const fieldConfigWithOptimalColorMode = adaptFieldColorMode(plugin, fieldConfigWithDefaults, isAfterPluginChange);

@mdvictor
Copy link
Contributor

mdvictor commented Nov 4, 2024

Fixed by grafana/scenes#950. Thank you for opening this issue!

@mdvictor mdvictor closed this as completed Nov 4, 2024
@github-project-automation github-project-automation bot moved this from 🗂️ Needs Triage / Escalation to 🚀 Done in Dashboards Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚀 Done
Development

Successfully merging a pull request may close this issue.

3 participants