Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-distributed] Tempo components doesn't reload config dynamically - Must Required Feature #3266

Open
vaibhhavv opened this issue Aug 8, 2024 · 0 comments

Comments

@vaibhhavv
Copy link

vaibhhavv commented Aug 8, 2024

As a user of tempo-distributed helm chart v1.16.0 into various production use cases, whenever I want to build a quick fix for any production issue, let's say I am changing some configurations in tempo.yaml or overrides.yaml configuration files.
After applying the configurations all the components pods restart and then load the new configuration.

The drawbacks related to the following approach are as follows:
1. If I am changing a parameter related to the querier, still the distributor is restarting along with all other components that have a dependency or no dependency on that config file.
2. Why does any component not work with the configuration auto reload approach? An automatic reload feature would be much more suitable for tempo-distributed architecture.

If we can do that, the following could be the benefits for the tempo:
1. Only dependent components should try to reload the configuration -> less downtime -> environment more stable.
2. We should have a built-in logic in all the dependent components for an automatic reload of configuration directly into the pod or as a sidecar -> Components will not have to restart every time -> Components like ingester which takes longer to load the WAL and get up, this time will get eliminated -> will lead tempo towards more stability.

If you also feel the need for this feature, please support the issue.

Thanks!

@vaibhhavv vaibhhavv changed the title [tempo-distributed] Tempo components doesn't reload config dynamically [tempo-distributed] Tempo components doesn't reload config dynamically - Must Required Feature Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant