-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release k6chaijs@4.5.0.1 #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just wondering, if we have added a new configuration/behavior, shouldn't it been v4.5.1, or even v4.6.0? 🤔 Or this doesn't follow some sort of semantic versioning?
@joanlopez In the README, we can see that our version should follow the chai version (see here). Since chai versions use only MAJOR, MINOR and PATCH numbers (in other words, the semver is in |
Ah, ah! Right! My mistake, and now that you mentioned, I remember to have the same thought and reading the same comment, so double fault! Apologies! 🙏🏻 |
Description
Release k6chaijs@4.5.0.1. This version adds support for `exitOnError" option. For more details, please see grafana/k6-jslib-k6chaijs@8eddf2d.
npm run test
command succeeds.yarn run generate-homepage
locally and verify the new homepage/lib/index.html
file looks legit.If publishing a new version of an existing jslib:
version bump
label./lib/{jslib_name}/{desired_version}
folder./lib/{jslib_name}/{desired_version}/index.js
file containing the jslib's code bundle.supported.json
file to contain an entry for the newly added jslib version, as in the following example:/tests/basic.js
and/tests/testSuite.js
files to ensure that the new version of the jslib is importable and runnable by k6.