-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to use gRPC Server Reflection #1930
Comments
IIRC, we didn't add server reflection initially because we tried to make the gRPC pull request an MVP of sorts, adding the bare minimum of features to try and minimize any breaking changes that may later be necessary. We didn't have xk6 as an experimental proving ground yet, so it was directly merged into the k6 core with a minimal amount of iteration 😅 But yes, server reflection is something we'd like to support. We don't plan on working on it ourselves soon, but we'll probably accept a good PR if someone submits it. If you're interested in working on this, please share your implementation ideas here, before opening a PR. I haven't looked into it, but this should probably be an optional feature, maybe a parameter to the gRPC |
Hey,
|
Would love to have seen this functionality in the latest dot release. Any reason why this wasn't included in v0.33? |
@juwatanabe, there were some issues with the PR (#1987) that weren't addressed in time for us to include it in v0.33.0. If they are fixed by the PR author or another contributor in roughly the next month, or if we have time to fix them ourselves, it should be included in v0.34.0. |
Hey I'm going to be working on this in the next couple of days (Apologies for the incorrect timeline; uni exams got in the way) |
Feature Description
gRPC Server reflection allow gRPC client to gRPC call without proto file.
https://github.com/grpc/grpc/blob/master/doc/server-reflection.md
ghz, is another gRPC load testing tool, supports this feature.
https://ghz.sh/docs/options#--proto
I saw this issue #441 (comment). in the issue, gRPC Server reflection feature is mentioned.
So I looked k6 issues&PRs about this feature but there isn't.
Do you have a plan for detail schedule for it?
Indeed, k6 is using this library https://github.com/jhump/protoreflect and it seems already to contain server reflection feature. https://github.com/jhump/protoreflect#grpc-server-reflection
Suggested Solution (optional)
I'm not sure but how about using server reflection feature in
jhump/protoreflect
?Maybe, Can this API be used? https://pkg.go.dev/github.com/jhump/protoreflect/grpcreflect#NewClient
The text was updated successfully, but these errors were encountered: