Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: Unit test the multi services fix #2295

Closed
codebien opened this issue Dec 13, 2021 · 0 comments · Fixed by #2301
Closed

grpc: Unit test the multi services fix #2295

codebien opened this issue Dec 13, 2021 · 0 comments · Fixed by #2301
Assignees
@codebien
Labels
tests

Comments

@codebien
Copy link
Contributor

codebien commented Dec 13, 2021 •
edited
Loading

#2265 introduced a fix for a proto file with multi-services defined. The new addition is not covered by unit tests. The suggestion is to add one for covering the added logic.

It would be nice to address also:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codebien codebien

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

js/grpc: Tests for multi services in same proto file grafana/k6
1 participant
@codebien