Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K6_BROWSER_ENABLED flag is redundant with browser type scenario option #3197

Closed
ka3de opened this issue Jul 14, 2023 · 0 comments · Fixed by #3235
Closed

K6_BROWSER_ENABLED flag is redundant with browser type scenario option #3197

ka3de opened this issue Jul 14, 2023 · 0 comments · Fixed by #3235
Assignees
Labels

Comments

@ka3de
Copy link
Contributor

ka3de commented Jul 14, 2023

Currently, as of commit a8ebe8c, the K6_BROWSER_ENABLED environment variable is redundant with the "browser type" option defined in the scenarios specification, as both of these are required in order to run a test that uses the browser module, being the latter one more restrictive as it must be set per scenario.
This is due to the changes applied in #3036 to support browser options inside scenarios definition in k6 core, and the modifications done in grafana/xk6-browser#944 in order to automatically initialize browsers based on this option.

From the k6 browser team we think that the usage of this flag is no longer required, and removing it will provide a better UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants