Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report whether a test was run from a CI environment in usage report data #4038

Closed
oleiade opened this issue Nov 5, 2024 · 4 comments · Fixed by #4063
Closed

Report whether a test was run from a CI environment in usage report data #4038

oleiade opened this issue Nov 5, 2024 · 4 comments · Fixed by #4063
Assignees
Labels
Milestone

Comments

@oleiade
Copy link
Member

oleiade commented Nov 5, 2024

Feature Description

k6 collects anonymized usage data with users content. In order to help us continue improving k6, we would like to add the information whether a test was run in a CI environment to such report.

Suggested Solution (optional)

The currently proposed solution is to look for the CI variable in the system's environment, and if set, update the usage report data accordingly (as proposed by @joanlopez).

Already existing or connected issues / PRs (optional)

No response

@oleiade oleiade added the feature label Nov 5, 2024
@oleiade
Copy link
Member Author

oleiade commented Nov 5, 2024

PS: The first naive solution sounds rather cheap to implement, and I'd really like to see this land in v0.56.0. What do you think @joanlopez @andrewslotin ?

@joanlopez
Copy link
Contributor

PS: The first naive solution sounds rather cheap to implement, and I'd really like to see this land in v0.56.0. What do you think @joanlopez @andrewslotin ?

It's likely going to be straightforward to implement, and I don't see many risks and/or potential blockers, beyond deciding how to name that indicator, and filling with a boolean stating whether the CI environment variable is defined or not.

Any other concerns? cc/ @grafana/k6-core

@andrewslotin
Copy link
Contributor

I like this proposal! Looks like a small change that would help us to understand how k6 is used in real life. Let do this!

@oleiade
Copy link
Member Author

oleiade commented Nov 6, 2024

Cheers folks, adding it to v0.56.0 milestone 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants