Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract js and js/modulestest parts that are to do with setupping the js environment into a single place #4069

Open
mstoykov opened this issue Nov 15, 2024 · 0 comments
Labels

Comments

@mstoykov
Copy link
Contributor

Currenlty both the js package and js/modulestest do a number of things to configure Sobek.runtime and modules.ModuleSystem in order to have the same behaviour.

This still doesn't actually make it so and does require that a number of realistically internal details are exported but are in practice only meant to be used internally:

Likely many more.

It also happens that we have two implementations that make it harder to work around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant