Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud requires 'target' in stages, conflicting with docs #648

Closed
countergram opened this issue May 24, 2018 · 3 comments
Closed

cloud requires 'target' in stages, conflicting with docs #648

countergram opened this issue May 24, 2018 · 3 comments

Comments

@countergram
Copy link

Documentation of 'options' contains the following stages:

stages: [
    { duration: "1m", target: 10 },
    { duration: "1m" },
    { duration: "1m", target: 0 }
  ],

However, k6 cloud throws this error:

ERRO[0001] 2 Invalid value for stages.1.target: None is not of type 'number'

@na-- na-- added this to the v1.0.0 milestone May 24, 2018
@na-- na-- added the cloud label May 25, 2018
@luizbafilho luizbafilho self-assigned this Jun 19, 2018
@luizbafilho
Copy link
Contributor

@robingustafsson this validation is coming from the cloud API. k6 itself allows empty target.

@na--
Copy link
Member

na-- commented Jun 20, 2018

Yep, that's why I tagged it as cloud 😄 Looking at this again, I'm not sure we should actually fix it and allow target to be omitted. It may save a few seconds for users, but it unnecessarily adds more confusion about how stages work. That would be especially bad once we add the arrival-rate based execution and/or some other execution mode like the log-based one. Or when we add different non-linear ramp-up/ramp-down strategies.

I feel like in this particular case, explicitness should trump conciseness and we should just edit the docs so we don't advertise support for this.

@luizbafilho
Copy link
Contributor

Added the target to every place that used stages in the documentation.

@na-- na-- removed this from the v1.0.0 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants