Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Detected labels from store #12441

Merged
merged 40 commits into from
Apr 23, 2024
Merged

feat: Detected labels from store #12441

merged 40 commits into from
Apr 23, 2024

Conversation

shantanualsi
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Re: #12341

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@shantanualsi shantanualsi changed the title Detected labels from store feat: Detected labels from store Apr 3, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 3, 2024
@shantanualsi
Copy link
Contributor Author

Note: This PR has #12505 already merged within. The diff will get smaller after the tests PR is merged first.

@shantanualsi shantanualsi marked this pull request as ready for review April 10, 2024 17:10
@shantanualsi
Copy link
Contributor Author

@trevorwhitney fixed all PR comments. Can you take a look again, thank you!

Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, thanks @shantanualsi! one question left about the slice.Contains vs using a map, wasn't sure where we landed with that? I'm fine if we want to keep it for now since it's such a small value, but something we should keep in mind if we plan to grow that in the future or allow each tenant to configure their own.

pkg/ingester/instance.go Show resolved Hide resolved
pkg/querier/querier.go Show resolved Hide resolved
pkg/querier/querier.go Outdated Show resolved Hide resolved
@trevorwhitney trevorwhitney merged commit 587a6d2 into main Apr 23, 2024
57 checks passed
@trevorwhitney trevorwhitney deleted the detected-labels-store branch April 23, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants